Commit 5ef6d8f4 authored by Bjorn Helgaas's avatar Bjorn Helgaas

agp/intel: Use pci_bus_address() to get MMADR bus address

Per the Intel 915G/915GV/... Chipset spec (document number 301467-005),
MMADR is a standard PCI BAR.

The PCI core reads MMADR at enumeration-time.  Use pci_bus_address()
instead of reading it again in the driver.  This works correctly for both
32-bit and 64-bit BARs.  The spec above only mentions 32-bit MMADR, but we
should still use the standard interface.

Also, stop clearing the low 19 bits of the bus address because it's invalid
to use addresses outside the region defined by the BAR.  The spec claims
MMADR is 512KB; if that's the case, those bits will be zero anyway.
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Reviewed-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent 545b0a74
...@@ -56,7 +56,7 @@ ...@@ -56,7 +56,7 @@
/* Intel i810 registers */ /* Intel i810 registers */
#define I810_GMADR_BAR 0 #define I810_GMADR_BAR 0
#define I810_MMADDR 0x14 #define I810_MMADR_BAR 1
#define I810_PTE_BASE 0x10000 #define I810_PTE_BASE 0x10000
#define I810_PTE_MAIN_UNCACHED 0x00000000 #define I810_PTE_MAIN_UNCACHED 0x00000000
#define I810_PTE_LOCAL 0x00000002 #define I810_PTE_LOCAL 0x00000002
...@@ -114,7 +114,7 @@ ...@@ -114,7 +114,7 @@
/* intel 915G registers */ /* intel 915G registers */
#define I915_GMADR_BAR 2 #define I915_GMADR_BAR 2
#define I915_MMADDR 0x10 #define I915_MMADR_BAR 0
#define I915_PTEADDR 0x1C #define I915_PTEADDR 0x1C
#define I915_GMCH_GMS_STOLEN_48M (0x6 << 4) #define I915_GMCH_GMS_STOLEN_48M (0x6 << 4)
#define I915_GMCH_GMS_STOLEN_64M (0x7 << 4) #define I915_GMCH_GMS_STOLEN_64M (0x7 << 4)
......
...@@ -181,8 +181,7 @@ static int i810_setup(void) ...@@ -181,8 +181,7 @@ static int i810_setup(void)
return -ENOMEM; return -ENOMEM;
intel_private.i81x_gtt_table = gtt_table; intel_private.i81x_gtt_table = gtt_table;
pci_read_config_dword(intel_private.pcidev, I810_MMADDR, &reg_addr); reg_addr = pci_bus_address(intel_private.pcidev, I810_MMADR_BAR);
reg_addr &= 0xfff80000;
intel_private.registers = ioremap(reg_addr, KB(64)); intel_private.registers = ioremap(reg_addr, KB(64));
if (!intel_private.registers) if (!intel_private.registers)
...@@ -785,8 +784,7 @@ static int i830_setup(void) ...@@ -785,8 +784,7 @@ static int i830_setup(void)
{ {
u32 reg_addr; u32 reg_addr;
pci_read_config_dword(intel_private.pcidev, I810_MMADDR, &reg_addr); reg_addr = pci_bus_address(intel_private.pcidev, I810_MMADR_BAR);
reg_addr &= 0xfff80000;
intel_private.registers = ioremap(reg_addr, KB(64)); intel_private.registers = ioremap(reg_addr, KB(64));
if (!intel_private.registers) if (!intel_private.registers)
...@@ -1107,9 +1105,7 @@ static int i9xx_setup(void) ...@@ -1107,9 +1105,7 @@ static int i9xx_setup(void)
u32 reg_addr, gtt_addr; u32 reg_addr, gtt_addr;
int size = KB(512); int size = KB(512);
pci_read_config_dword(intel_private.pcidev, I915_MMADDR, &reg_addr); reg_addr = pci_bus_address(intel_private.pcidev, I915_MMADR_BAR);
reg_addr &= 0xfff80000;
intel_private.registers = ioremap(reg_addr, size); intel_private.registers = ioremap(reg_addr, size);
if (!intel_private.registers) if (!intel_private.registers)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment