Commit 62176420 authored by Thomas Weißschuh's avatar Thomas Weißschuh Committed by Christian Brauner

fs: avoid empty option when generating legacy mount string

As each option string fragment is always prepended with a comma it would
happen that the whole string always starts with a comma. This could be
interpreted by filesystem drivers as an empty option and may produce
errors.

For example the NTFS driver from ntfs.ko behaves like this and fails
when mounted via the new API.

Link: https://github.com/util-linux/util-linux/issues/2298Signed-off-by: default avatarThomas Weißschuh <linux@weissschuh.net>
Fixes: 3e1aeb00 ("vfs: Implement a filesystem superblock creation/configuration context")
Cc: stable@vger.kernel.org
Message-Id: <20230607-fs-empty-option-v1-1-20c8dbf4671b@weissschuh.net>
Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent 943211c8
...@@ -561,7 +561,8 @@ static int legacy_parse_param(struct fs_context *fc, struct fs_parameter *param) ...@@ -561,7 +561,8 @@ static int legacy_parse_param(struct fs_context *fc, struct fs_parameter *param)
return -ENOMEM; return -ENOMEM;
} }
ctx->legacy_data[size++] = ','; if (size)
ctx->legacy_data[size++] = ',';
len = strlen(param->key); len = strlen(param->key);
memcpy(ctx->legacy_data + size, param->key, len); memcpy(ctx->legacy_data + size, param->key, len);
size += len; size += len;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment