Commit 6218b88d authored by Thomas Gleixner's avatar Thomas Gleixner

gpio/dwapb: Fix race in installing chained IRQ handler

Fix a race where a pending interrupt could be received and the handler
called before the handler's data has been setup, by converting to
irq_set_chained_handler_and_data().

Search and conversion was done with coccinelle:

@@
expression E1, E2, E3;
@@
(
-if (irq_set_chained_handler(E1, E3) != 0)
-   BUG();
|
-irq_set_chained_handler(E1, E3);
)
-irq_set_handler_data(E1, E2);
+irq_set_chained_handler_and_data(E1, E3, E2);

@@
expression E1, E2, E3;
@@
(
-if (irq_set_chained_handler(E1, E3) != 0)
-   BUG();
...
|
-irq_set_chained_handler(E1, E3);
...
)
-irq_set_handler_data(E1, E2);
+irq_set_chained_handler_and_data(E1, E3, E2);
Reported-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Cc: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Alexandre Courbot <gnurou@gmail.com>
Cc: linux-gpio@vger.kernel.org
parent b34cc620
...@@ -348,8 +348,8 @@ static void dwapb_configure_irqs(struct dwapb_gpio *gpio, ...@@ -348,8 +348,8 @@ static void dwapb_configure_irqs(struct dwapb_gpio *gpio,
irq_gc->chip_types[1].handler = handle_edge_irq; irq_gc->chip_types[1].handler = handle_edge_irq;
if (!pp->irq_shared) { if (!pp->irq_shared) {
irq_set_chained_handler(pp->irq, dwapb_irq_handler); irq_set_chained_handler_and_data(pp->irq, dwapb_irq_handler,
irq_set_handler_data(pp->irq, gpio); gpio);
} else { } else {
/* /*
* Request a shared IRQ since where MFD would have devices * Request a shared IRQ since where MFD would have devices
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment