Commit 62765d39 authored by Jia-Ju Bai's avatar Jia-Ju Bai Committed by David S. Miller

net: wan: fix error return code of uhdlc_init()

When priv->rx_skbuff or priv->tx_skbuff is NULL, no error return code of
uhdlc_init() is assigned.
To fix this bug, ret is assigned with -ENOMEM in these cases.
Reported-by: default avatarTOTE Robot <oslab@tsinghua.edu.cn>
Signed-off-by: default avatarJia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 143c253f
...@@ -204,14 +204,18 @@ static int uhdlc_init(struct ucc_hdlc_private *priv) ...@@ -204,14 +204,18 @@ static int uhdlc_init(struct ucc_hdlc_private *priv)
priv->rx_skbuff = kcalloc(priv->rx_ring_size, priv->rx_skbuff = kcalloc(priv->rx_ring_size,
sizeof(*priv->rx_skbuff), sizeof(*priv->rx_skbuff),
GFP_KERNEL); GFP_KERNEL);
if (!priv->rx_skbuff) if (!priv->rx_skbuff) {
ret = -ENOMEM;
goto free_ucc_pram; goto free_ucc_pram;
}
priv->tx_skbuff = kcalloc(priv->tx_ring_size, priv->tx_skbuff = kcalloc(priv->tx_ring_size,
sizeof(*priv->tx_skbuff), sizeof(*priv->tx_skbuff),
GFP_KERNEL); GFP_KERNEL);
if (!priv->tx_skbuff) if (!priv->tx_skbuff) {
ret = -ENOMEM;
goto free_rx_skbuff; goto free_rx_skbuff;
}
priv->skb_curtx = 0; priv->skb_curtx = 0;
priv->skb_dirtytx = 0; priv->skb_dirtytx = 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment