Commit 62eebd52 authored by Qinglang Miao's avatar Qinglang Miao Committed by Martin K. Petersen

scsi: qedi: Fix missing destroy_workqueue() on error in __qedi_probe

Add the missing destroy_workqueue() before return from __qedi_probe in the
error handling case when fails to create workqueue qedi->offload_thread.

Link: https://lore.kernel.org/r/20201109091518.55941-1-miaoqinglang@huawei.com
Fixes: ace7f46b ("scsi: qedi: Add QLogic FastLinQ offload iSCSI driver framework.")
Reviewed-by: default avatarMike Christie <michael.christie@oracle.com>
Signed-off-by: default avatarQinglang Miao <miaoqinglang@huawei.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 492096ec
...@@ -2766,7 +2766,7 @@ static int __qedi_probe(struct pci_dev *pdev, int mode) ...@@ -2766,7 +2766,7 @@ static int __qedi_probe(struct pci_dev *pdev, int mode)
QEDI_ERR(&qedi->dbg_ctx, QEDI_ERR(&qedi->dbg_ctx,
"Unable to start offload thread!\n"); "Unable to start offload thread!\n");
rc = -ENODEV; rc = -ENODEV;
goto free_cid_que; goto free_tmf_thread;
} }
INIT_DELAYED_WORK(&qedi->recovery_work, qedi_recovery_handler); INIT_DELAYED_WORK(&qedi->recovery_work, qedi_recovery_handler);
...@@ -2790,6 +2790,8 @@ static int __qedi_probe(struct pci_dev *pdev, int mode) ...@@ -2790,6 +2790,8 @@ static int __qedi_probe(struct pci_dev *pdev, int mode)
return 0; return 0;
free_tmf_thread:
destroy_workqueue(qedi->tmf_thread);
free_cid_que: free_cid_que:
qedi_release_cid_que(qedi); qedi_release_cid_que(qedi);
free_uio: free_uio:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment