Commit 64e862a5 authored by Corey Minyard's avatar Corey Minyard Committed by Linus Torvalds

IPMI: fix comparison in demangle_device_id

Coverity spotted some incorrect code in a recent change to the IPMI driver;
this patch make sure the data is really long enough to pull the
manufacturer id and product id out of a get device id message.
Signed-off-by: default avatarCorey Minyard <cminyard@mvista.com>
Cc: Adrian Bunk <bunk@kernel.org>
Cc: Stian Jordet <liste@jordet.net>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent cc5f916e
...@@ -173,7 +173,7 @@ static inline int ipmi_demangle_device_id(const unsigned char *data, ...@@ -173,7 +173,7 @@ static inline int ipmi_demangle_device_id(const unsigned char *data,
id->firmware_revision_2 = data[3]; id->firmware_revision_2 = data[3];
id->ipmi_version = data[4]; id->ipmi_version = data[4];
id->additional_device_support = data[5]; id->additional_device_support = data[5];
if (data_len >= 6) { if (data_len >= 11) {
id->manufacturer_id = (data[6] | (data[7] << 8) | id->manufacturer_id = (data[6] | (data[7] << 8) |
(data[8] << 16)); (data[8] << 16));
id->product_id = data[9] | (data[10] << 8); id->product_id = data[9] | (data[10] << 8);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment