Commit 64ff90cc authored by Xin Long's avatar Xin Long Committed by David S. Miller

rtnetlink: check DO_SETLINK_NOTIFY correctly in do_setlink

The check 'status & DO_SETLINK_NOTIFY' in do_setlink doesn't really
work after status & DO_SETLINK_MODIFIED, as:

  DO_SETLINK_MODIFIED 0x1
  DO_SETLINK_NOTIFY 0x3

Considering that notifications are suppposed to be sent only when
status have the flag DO_SETLINK_NOTIFY, the right check would be:

  (status & DO_SETLINK_NOTIFY) == DO_SETLINK_NOTIFY

This would avoid lots of duplicated notifications when setting some
properties of a link.

Fixes: ba998906 ("rtnl/do_setlink(): notify when a netdev is modified")
Signed-off-by: default avatarXin Long <lucien.xin@gmail.com>
Acked-by: default avatarDavid Ahern <dsahern@gmail.com>
Acked-by: default avatarNicolas Dichtel <nicolas.dichtel@6wind.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent dc709f37
...@@ -2248,7 +2248,7 @@ static int do_setlink(const struct sk_buff *skb, ...@@ -2248,7 +2248,7 @@ static int do_setlink(const struct sk_buff *skb,
errout: errout:
if (status & DO_SETLINK_MODIFIED) { if (status & DO_SETLINK_MODIFIED) {
if (status & DO_SETLINK_NOTIFY) if ((status & DO_SETLINK_NOTIFY) == DO_SETLINK_NOTIFY)
netdev_state_change(dev); netdev_state_change(dev);
if (err < 0) if (err < 0)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment