Commit 650c8496 authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller

x86: bpf_jit_comp: can call module_free() from any context

It looks like we can call module_free()/vfree() from softirq context,
so no longer need a wrapper and a work_struct.
Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Cc: Al Viro <viro@ZenIV.linux.org.uk>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b4236daa
...@@ -717,9 +717,7 @@ cond_branch: f_offset = addrs[i + filter[i].jf] - addrs[i]; ...@@ -717,9 +717,7 @@ cond_branch: f_offset = addrs[i + filter[i].jf] - addrs[i];
break; break;
} }
if (proglen == oldproglen) { if (proglen == oldproglen) {
image = module_alloc(max_t(unsigned int, image = module_alloc(proglen);
proglen,
sizeof(struct work_struct)));
if (!image) if (!image)
goto out; goto out;
} }
...@@ -738,20 +736,8 @@ cond_branch: f_offset = addrs[i + filter[i].jf] - addrs[i]; ...@@ -738,20 +736,8 @@ cond_branch: f_offset = addrs[i + filter[i].jf] - addrs[i];
return; return;
} }
static void jit_free_defer(struct work_struct *arg)
{
module_free(NULL, arg);
}
/* run from softirq, we must use a work_struct to call
* module_free() from process context
*/
void bpf_jit_free(struct sk_filter *fp) void bpf_jit_free(struct sk_filter *fp)
{ {
if (fp->bpf_func != sk_run_filter) { if (fp->bpf_func != sk_run_filter)
struct work_struct *work = (struct work_struct *)fp->bpf_func; module_free(NULL, fp->bpf_func);
INIT_WORK(work, jit_free_defer);
schedule_work(work);
}
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment