Commit 651dd54f authored by Hans de Goede's avatar Hans de Goede Committed by Greg Kroah-Hartman

ACPI / video: Fix use_native_backlight selection logic

commit 25294e9f upstream.

Commit 751109aa ("ACPI / video: Change the default for
video.use_native_backlight to 1") has changed the default for
use_native_backlight from 0 to 1, but instead of changing
use_native_backlight_dmi to true, and leaving use_native_backlight_param at -1,
it has changed use_native_backlight_param to 1.

This causes acpi_video_use_native_backlight() to always think that a value was
specified through the param, making it impossible to add a dmi based quirk
to force 0 now that the default is 1.

This fixes this by restoring the use_native_backlight_param default to -1, and
instead setting the use_native_backlight_dmi default to true.

Fixes: 751109aa (ACPI / video: Change the default for video.use_native_backlight to 1)
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent d1c06203
...@@ -82,9 +82,9 @@ module_param(allow_duplicates, bool, 0644); ...@@ -82,9 +82,9 @@ module_param(allow_duplicates, bool, 0644);
* For Windows 8 systems: used to decide if video module * For Windows 8 systems: used to decide if video module
* should skip registering backlight interface of its own. * should skip registering backlight interface of its own.
*/ */
static int use_native_backlight_param = 1; static int use_native_backlight_param = -1;
module_param_named(use_native_backlight, use_native_backlight_param, int, 0444); module_param_named(use_native_backlight, use_native_backlight_param, int, 0444);
static bool use_native_backlight_dmi = false; static bool use_native_backlight_dmi = true;
static int register_count; static int register_count;
static struct mutex video_list_lock; static struct mutex video_list_lock;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment