Commit 65b37df8 authored by Ian Rogers's avatar Ian Rogers Committed by Namhyung Kim

perf test pmu: Warn don't fail for legacy mixed case event names

PowerPC has mixed case events matching legacy hardware cache
events. Warn but don't fail in this case. Event parsing will still
work in this case by matching the legacy case.
Signed-off-by: default avatarIan Rogers <irogers@google.com>
Tested-by: default avatarKajol Jain <kjain@linux.ibm.com>
Cc: James Clark <james.clark@arm.com>
Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
Link: https://lore.kernel.org/r/20240612124027.2712643-1-irogers@google.com
parent 245b0edf
...@@ -260,26 +260,42 @@ static int test__pmu_events(struct test_suite *test __maybe_unused, int subtest ...@@ -260,26 +260,42 @@ static int test__pmu_events(struct test_suite *test __maybe_unused, int subtest
static bool permitted_event_name(const char *name) static bool permitted_event_name(const char *name)
{ {
bool has_lower = false, has_upper = false; bool has_lower = false, has_upper = false;
__u64 config;
for (size_t i = 0; i < strlen(name); i++) { for (size_t i = 0; i < strlen(name); i++) {
char c = name[i]; char c = name[i];
if (islower(c)) { if (islower(c)) {
if (has_upper) if (has_upper)
return false; goto check_legacy;
has_lower = true; has_lower = true;
continue; continue;
} }
if (isupper(c)) { if (isupper(c)) {
if (has_lower) if (has_lower)
return false; goto check_legacy;
has_upper = true; has_upper = true;
continue; continue;
} }
if (!isdigit(c) && c != '.' && c != '_' && c != '-') if (!isdigit(c) && c != '.' && c != '_' && c != '-')
return false; goto check_legacy;
} }
return true; return true;
check_legacy:
/*
* If the event name matches a legacy cache name the legacy encoding
* will still be used. This isn't quite WAI as sysfs events should take
* priority, but this case happens on PowerPC and matches the behavior
* in older perf tools where legacy events were the priority. Be
* permissive and assume later PMU drivers will use all lower or upper
* case names.
*/
if (parse_events__decode_legacy_cache(name, /*extended_pmu_type=*/0, &config) == 0) {
pr_warning("sysfs event '%s' should be all lower/upper case, it will be matched using legacy encoding.",
name);
return true;
}
return false;
} }
static int test__pmu_event_names(struct test_suite *test __maybe_unused, static int test__pmu_event_names(struct test_suite *test __maybe_unused,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment