Commit 6799b698 authored by Zhang Yi's avatar Zhang Yi Committed by Andrew Morton

ufs: replace ll_rw_block()

ll_rw_block() is not safe for the sync read path because it cannot
guarantee that submitting read IO if the buffer has been locked. We
could get false positive EIO after wait_on_buffer() if the buffer has
been locked by others. So stop using ll_rw_block() in ufs.

Link: https://lkml.kernel.org/r/20220901133505.2510834-12-yi.zhang@huawei.comSigned-off-by: default avatarZhang Yi <yi.zhang@huawei.com>
Reviewed-by: default avatarJan Kara <jack@suse.cz>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 59a16786
...@@ -295,15 +295,11 @@ static void ufs_change_blocknr(struct inode *inode, sector_t beg, ...@@ -295,15 +295,11 @@ static void ufs_change_blocknr(struct inode *inode, sector_t beg,
if (!buffer_mapped(bh)) if (!buffer_mapped(bh))
map_bh(bh, inode->i_sb, oldb + pos); map_bh(bh, inode->i_sb, oldb + pos);
if (!buffer_uptodate(bh)) { if (bh_read(bh, 0) < 0) {
ll_rw_block(REQ_OP_READ, 1, &bh);
wait_on_buffer(bh);
if (!buffer_uptodate(bh)) {
ufs_error(inode->i_sb, __func__, ufs_error(inode->i_sb, __func__,
"read of block failed\n"); "read of block failed\n");
break; break;
} }
}
UFSD(" change from %llu to %llu, pos %u\n", UFSD(" change from %llu to %llu, pos %u\n",
(unsigned long long)(pos + oldb), (unsigned long long)(pos + oldb),
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment