Commit 67c50bf2 authored by Martin Kepplinger's avatar Martin Kepplinger Committed by Rusty Russell

lguest: explicitly set miscdevice's private_data NULL

There is a proposed change to the miscdevice's behaviour on open(). Currently
file->private_data stays NULL, but only because we don't have an open-entry in
struct file_operations.

This may change so that private_data, more consistently, is always set to
struct miscdevice, not only *if* the driver has it's own open() routine and
fops-entry, see https://lkml.org/lkml/2014/12/4/939 and commit
94e4fe2c

In short: If we rely on file->private_data being NULL, we should ensure
it is NULL ourselves.
Signed-off-by: default avatarMartin Kepplinger <martink@posteo.de>
Signed-off-by: default avatarRusty Russell <rusty@rustcorp.com.au>
parent 88ad1a14
...@@ -339,6 +339,13 @@ static ssize_t write(struct file *file, const char __user *in, ...@@ -339,6 +339,13 @@ static ssize_t write(struct file *file, const char __user *in,
} }
} }
static int open(struct inode *inode, struct file *file)
{
file->private_data = NULL;
return 0;
}
/*L:060 /*L:060
* The final piece of interface code is the close() routine. It reverses * The final piece of interface code is the close() routine. It reverses
* everything done in initialize(). This is usually called because the * everything done in initialize(). This is usually called because the
...@@ -409,6 +416,7 @@ static int close(struct inode *inode, struct file *file) ...@@ -409,6 +416,7 @@ static int close(struct inode *inode, struct file *file)
*/ */
static const struct file_operations lguest_fops = { static const struct file_operations lguest_fops = {
.owner = THIS_MODULE, .owner = THIS_MODULE,
.open = open,
.release = close, .release = close,
.write = write, .write = write,
.read = read, .read = read,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment