Commit 68281619 authored by Rafał Miłecki's avatar Rafał Miłecki Committed by Jiri Slaby

mtd: bcm47xxpart: fix parsing first block after aligned TRX

commit bd5d2131 upstream.

After parsing TRX we should skip to the first block placed behind it.
Our code was working only with TRX with length not aligned to the
blocksize. In other cases (length aligned) it was missing the block
places right after TRX.

This fixes calculation and simplifies the comment.
Signed-off-by: default avatarRafał Miłecki <rafal@milecki.pl>
Signed-off-by: default avatarBrian Norris <computersforpeace@gmail.com>
Signed-off-by: default avatarAmit Pundir <amit.pundir@linaro.org>
Signed-off-by: default avatarJiri Slaby <jslaby@suse.cz>
parent 45f27a17
...@@ -159,12 +159,10 @@ static int bcm47xxpart_parse(struct mtd_info *master, ...@@ -159,12 +159,10 @@ static int bcm47xxpart_parse(struct mtd_info *master,
last_trx_part = curr_part - 1; last_trx_part = curr_part - 1;
/* /* Jump to the end of TRX */
* We have whole TRX scanned, skip to the next part. Use offset = roundup(offset + trx->length, blocksize);
* roundown (not roundup), as the loop will increase /* Next loop iteration will increase the offset */
* offset in next step. offset -= blocksize;
*/
offset = rounddown(offset + trx->length, blocksize);
continue; continue;
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment