Commit 682881ee authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller

net: sched: act_police: fix sparse errors in tcf_police_dump()

Fixes following sparse errors:

net/sched/act_police.c:360:28: warning: dereference of noderef expression
net/sched/act_police.c:362:45: warning: dereference of noderef expression
net/sched/act_police.c:362:45: warning: dereference of noderef expression
net/sched/act_police.c:368:28: warning: dereference of noderef expression
net/sched/act_police.c:370:45: warning: dereference of noderef expression
net/sched/act_police.c:370:45: warning: dereference of noderef expression
net/sched/act_police.c:376:45: warning: dereference of noderef expression
net/sched/act_police.c:376:45: warning: dereference of noderef expression

Fixes: d1967e49 ("net_sched: act_police: add 2 new attributes to support police 64bit rate and peakrate")
Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Reviewed-by: default avatarSimon Horman <simon.horman@corigine.com>
Acked-by: default avatarJamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent de9df6c6
...@@ -357,23 +357,23 @@ static int tcf_police_dump(struct sk_buff *skb, struct tc_action *a, ...@@ -357,23 +357,23 @@ static int tcf_police_dump(struct sk_buff *skb, struct tc_action *a,
opt.burst = PSCHED_NS2TICKS(p->tcfp_burst); opt.burst = PSCHED_NS2TICKS(p->tcfp_burst);
if (p->rate_present) { if (p->rate_present) {
psched_ratecfg_getrate(&opt.rate, &p->rate); psched_ratecfg_getrate(&opt.rate, &p->rate);
if ((police->params->rate.rate_bytes_ps >= (1ULL << 32)) && if ((p->rate.rate_bytes_ps >= (1ULL << 32)) &&
nla_put_u64_64bit(skb, TCA_POLICE_RATE64, nla_put_u64_64bit(skb, TCA_POLICE_RATE64,
police->params->rate.rate_bytes_ps, p->rate.rate_bytes_ps,
TCA_POLICE_PAD)) TCA_POLICE_PAD))
goto nla_put_failure; goto nla_put_failure;
} }
if (p->peak_present) { if (p->peak_present) {
psched_ratecfg_getrate(&opt.peakrate, &p->peak); psched_ratecfg_getrate(&opt.peakrate, &p->peak);
if ((police->params->peak.rate_bytes_ps >= (1ULL << 32)) && if ((p->peak.rate_bytes_ps >= (1ULL << 32)) &&
nla_put_u64_64bit(skb, TCA_POLICE_PEAKRATE64, nla_put_u64_64bit(skb, TCA_POLICE_PEAKRATE64,
police->params->peak.rate_bytes_ps, p->peak.rate_bytes_ps,
TCA_POLICE_PAD)) TCA_POLICE_PAD))
goto nla_put_failure; goto nla_put_failure;
} }
if (p->pps_present) { if (p->pps_present) {
if (nla_put_u64_64bit(skb, TCA_POLICE_PKTRATE64, if (nla_put_u64_64bit(skb, TCA_POLICE_PKTRATE64,
police->params->ppsrate.rate_pkts_ps, p->ppsrate.rate_pkts_ps,
TCA_POLICE_PAD)) TCA_POLICE_PAD))
goto nla_put_failure; goto nla_put_failure;
if (nla_put_u64_64bit(skb, TCA_POLICE_PKTBURST64, if (nla_put_u64_64bit(skb, TCA_POLICE_PKTBURST64,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment