Commit 68351b58 authored by Jingoo Han's avatar Jingoo Han Committed by John W. Linville

wireless: orinoco: remove unnecessary pci_set_drvdata()

The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: default avatarJingoo Han <jg1.han@samsung.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent e53c61a0
...@@ -234,7 +234,6 @@ static int orinoco_nortel_init_one(struct pci_dev *pdev, ...@@ -234,7 +234,6 @@ static int orinoco_nortel_init_one(struct pci_dev *pdev,
free_irq(pdev->irq, priv); free_irq(pdev->irq, priv);
fail_irq: fail_irq:
pci_set_drvdata(pdev, NULL);
free_orinocodev(priv); free_orinocodev(priv);
fail_alloc: fail_alloc:
...@@ -265,7 +264,6 @@ static void orinoco_nortel_remove_one(struct pci_dev *pdev) ...@@ -265,7 +264,6 @@ static void orinoco_nortel_remove_one(struct pci_dev *pdev)
orinoco_if_del(priv); orinoco_if_del(priv);
free_irq(pdev->irq, priv); free_irq(pdev->irq, priv);
pci_set_drvdata(pdev, NULL);
free_orinocodev(priv); free_orinocodev(priv);
pci_iounmap(pdev, priv->hw.iobase); pci_iounmap(pdev, priv->hw.iobase);
pci_iounmap(pdev, card->attr_io); pci_iounmap(pdev, card->attr_io);
......
...@@ -184,7 +184,6 @@ static int orinoco_pci_init_one(struct pci_dev *pdev, ...@@ -184,7 +184,6 @@ static int orinoco_pci_init_one(struct pci_dev *pdev,
free_irq(pdev->irq, priv); free_irq(pdev->irq, priv);
fail_irq: fail_irq:
pci_set_drvdata(pdev, NULL);
free_orinocodev(priv); free_orinocodev(priv);
fail_alloc: fail_alloc:
...@@ -205,7 +204,6 @@ static void orinoco_pci_remove_one(struct pci_dev *pdev) ...@@ -205,7 +204,6 @@ static void orinoco_pci_remove_one(struct pci_dev *pdev)
orinoco_if_del(priv); orinoco_if_del(priv);
free_irq(pdev->irq, priv); free_irq(pdev->irq, priv);
pci_set_drvdata(pdev, NULL);
free_orinocodev(priv); free_orinocodev(priv);
pci_iounmap(pdev, priv->hw.iobase); pci_iounmap(pdev, priv->hw.iobase);
pci_release_regions(pdev); pci_release_regions(pdev);
......
...@@ -273,7 +273,6 @@ static int orinoco_plx_init_one(struct pci_dev *pdev, ...@@ -273,7 +273,6 @@ static int orinoco_plx_init_one(struct pci_dev *pdev,
free_irq(pdev->irq, priv); free_irq(pdev->irq, priv);
fail_irq: fail_irq:
pci_set_drvdata(pdev, NULL);
free_orinocodev(priv); free_orinocodev(priv);
fail_alloc: fail_alloc:
...@@ -301,7 +300,6 @@ static void orinoco_plx_remove_one(struct pci_dev *pdev) ...@@ -301,7 +300,6 @@ static void orinoco_plx_remove_one(struct pci_dev *pdev)
orinoco_if_del(priv); orinoco_if_del(priv);
free_irq(pdev->irq, priv); free_irq(pdev->irq, priv);
pci_set_drvdata(pdev, NULL);
free_orinocodev(priv); free_orinocodev(priv);
pci_iounmap(pdev, priv->hw.iobase); pci_iounmap(pdev, priv->hw.iobase);
pci_iounmap(pdev, card->attr_io); pci_iounmap(pdev, card->attr_io);
......
...@@ -170,7 +170,6 @@ static int orinoco_tmd_init_one(struct pci_dev *pdev, ...@@ -170,7 +170,6 @@ static int orinoco_tmd_init_one(struct pci_dev *pdev,
free_irq(pdev->irq, priv); free_irq(pdev->irq, priv);
fail_irq: fail_irq:
pci_set_drvdata(pdev, NULL);
free_orinocodev(priv); free_orinocodev(priv);
fail_alloc: fail_alloc:
...@@ -195,7 +194,6 @@ static void orinoco_tmd_remove_one(struct pci_dev *pdev) ...@@ -195,7 +194,6 @@ static void orinoco_tmd_remove_one(struct pci_dev *pdev)
orinoco_if_del(priv); orinoco_if_del(priv);
free_irq(pdev->irq, priv); free_irq(pdev->irq, priv);
pci_set_drvdata(pdev, NULL);
free_orinocodev(priv); free_orinocodev(priv);
pci_iounmap(pdev, priv->hw.iobase); pci_iounmap(pdev, priv->hw.iobase);
pci_iounmap(pdev, card->bridge_io); pci_iounmap(pdev, card->bridge_io);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment