Commit 689e6b53 authored by Thomas Gleixner's avatar Thomas Gleixner

PCI/MSI: Correct misleading comments

The comments about preserving the cached state in pci_msi[x]_shutdown() are
misleading as the MSI descriptors are freed right after those functions
return. So there is nothing to restore. Preparatory change.
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Tested-by: default avatarMarc Zyngier <maz@kernel.org>
Reviewed-by: default avatarMarc Zyngier <maz@kernel.org>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20210729222542.621609423@linutronix.de
parent 361fd373
...@@ -961,7 +961,6 @@ static void pci_msi_shutdown(struct pci_dev *dev) ...@@ -961,7 +961,6 @@ static void pci_msi_shutdown(struct pci_dev *dev)
/* Return the device with MSI unmasked as initial states */ /* Return the device with MSI unmasked as initial states */
mask = msi_mask(desc->msi_attrib.multi_cap); mask = msi_mask(desc->msi_attrib.multi_cap);
/* Keep cached state to be restored */
__pci_msi_desc_mask_irq(desc, mask, 0); __pci_msi_desc_mask_irq(desc, mask, 0);
/* Restore dev->irq to its default pin-assertion IRQ */ /* Restore dev->irq to its default pin-assertion IRQ */
...@@ -1047,10 +1046,8 @@ static void pci_msix_shutdown(struct pci_dev *dev) ...@@ -1047,10 +1046,8 @@ static void pci_msix_shutdown(struct pci_dev *dev)
} }
/* Return the device with MSI-X masked as initial states */ /* Return the device with MSI-X masked as initial states */
for_each_pci_msi_entry(entry, dev) { for_each_pci_msi_entry(entry, dev)
/* Keep cached states to be restored */
__pci_msix_desc_mask_irq(entry, 1); __pci_msix_desc_mask_irq(entry, 1);
}
pci_msix_clear_and_set_ctrl(dev, PCI_MSIX_FLAGS_ENABLE, 0); pci_msix_clear_and_set_ctrl(dev, PCI_MSIX_FLAGS_ENABLE, 0);
pci_intx_for_msi(dev, 1); pci_intx_for_msi(dev, 1);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment