Commit 68ef1692 authored by Mitch Williams's avatar Mitch Williams Committed by Jeff Kirsher

i40evf: don't delete all the filters

Due to an inverted conditional, the driver was marking all of its MAC
filters for deletion every time set_rx_mode was called. Depending upon
the timing of the calls to set_rx_mode and the processing of the admin
queue, the driver would (accidentally) end up with a varying number of
functional filters.

Correct this logic so that MAC filters are added and removed correctly.
Add a check for the driver's "hardware" MAC address so that this filter
doesn't get removed incorrectly.

Change-ID: Ib3e7c4a5b53df6835f164fe44cb778cb71f8aff8
Signed-off-by: default avatarMitch Williams <mitch.a.williams@intel.com>
Tested-by: default avatarJim Young <james.m.young@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent 5b8f8505
...@@ -892,8 +892,10 @@ static void i40evf_set_rx_mode(struct net_device *netdev) ...@@ -892,8 +892,10 @@ static void i40evf_set_rx_mode(struct net_device *netdev)
break; break;
} }
} }
if (ether_addr_equal(f->macaddr, adapter->hw.mac.addr))
found = true;
} }
if (found) { if (!found) {
f->remove = true; f->remove = true;
adapter->aq_required |= I40EVF_FLAG_AQ_DEL_MAC_FILTER; adapter->aq_required |= I40EVF_FLAG_AQ_DEL_MAC_FILTER;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment