Commit 6903ffb2 authored by Andy Whitcroft's avatar Andy Whitcroft Committed by Linus Torvalds

checkpatch: struct seq_operations should normally be const

In the general use case struct seq_operations should be a const object.
Check for and warn where it is not.

Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: default avatarAndy Whitcroft <apw@canonical.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 39667782
...@@ -2527,9 +2527,10 @@ sub process { ...@@ -2527,9 +2527,10 @@ sub process {
WARN("please use device_initcall() instead of __initcall()\n" . $herecurr); WARN("please use device_initcall() instead of __initcall()\n" . $herecurr);
} }
# check for struct file_operations, ensure they are const. # check for struct file_operations, ensure they are const.
if ($line =~ /\bstruct\s+file_operations\b/ && if ($line !~ /\bconst\b/ &&
$line !~ /\bconst\b/) { $line =~ /\bstruct\s+(file_operations|seq_operations)\b/) {
WARN("struct file_operations should normally be const\n" . $herecurr); WARN("struct $1 should normally be const\n" .
$herecurr);
} }
# use of NR_CPUS is usually wrong # use of NR_CPUS is usually wrong
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment