Commit 690e781c authored by Dan Carpenter's avatar Dan Carpenter Committed by John W. Linville

ath9k_htc: dereferencing before check in hif_usb_tx_cb()

After c11d8f89: "ath9k_htc: Simplify TX URB management" we no longer
assume that tx_buf is a non-null pointer.
Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Acked-by: default avatarSujith <Sujith.Manoharan@atheros.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 663cb47c
...@@ -107,12 +107,14 @@ static inline void ath9k_skb_queue_purge(struct hif_device_usb *hif_dev, ...@@ -107,12 +107,14 @@ static inline void ath9k_skb_queue_purge(struct hif_device_usb *hif_dev,
static void hif_usb_tx_cb(struct urb *urb) static void hif_usb_tx_cb(struct urb *urb)
{ {
struct tx_buf *tx_buf = (struct tx_buf *) urb->context; struct tx_buf *tx_buf = (struct tx_buf *) urb->context;
struct hif_device_usb *hif_dev = tx_buf->hif_dev; struct hif_device_usb *hif_dev;
struct sk_buff *skb; struct sk_buff *skb;
if (!hif_dev || !tx_buf) if (!tx_buf || !tx_buf->hif_dev)
return; return;
hif_dev = tx_buf->hif_dev;
switch (urb->status) { switch (urb->status) {
case 0: case 0:
break; break;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment