Commit 696dbe45 authored by Guenter Roeck's avatar Guenter Roeck

hwmon: (max1668) Use BIT macro

Use bit macro to make the code easier to understand and reduce duplication.
Reviewed-by: default avatarTzung-Bi Shih <tzungbi@kernel.org>
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 74b6451b
...@@ -6,6 +6,7 @@ ...@@ -6,6 +6,7 @@
* some credit to Christoph Scheurer, but largely a rewrite * some credit to Christoph Scheurer, but largely a rewrite
*/ */
#include <linux/bits.h>
#include <linux/err.h> #include <linux/err.h>
#include <linux/hwmon.h> #include <linux/hwmon.h>
#include <linux/hwmon-sysfs.h> #include <linux/hwmon-sysfs.h>
...@@ -172,7 +173,7 @@ static ssize_t show_alarm(struct device *dev, struct device_attribute *attr, ...@@ -172,7 +173,7 @@ static ssize_t show_alarm(struct device *dev, struct device_attribute *attr,
if (IS_ERR(data)) if (IS_ERR(data))
return PTR_ERR(data); return PTR_ERR(data);
return sprintf(buf, "%u\n", (data->alarms >> index) & 0x1); return sprintf(buf, "%u\n", !!(data->alarms & BIT(index)));
} }
static ssize_t show_fault(struct device *dev, static ssize_t show_fault(struct device *dev,
...@@ -185,7 +186,7 @@ static ssize_t show_fault(struct device *dev, ...@@ -185,7 +186,7 @@ static ssize_t show_fault(struct device *dev,
return PTR_ERR(data); return PTR_ERR(data);
return sprintf(buf, "%u\n", return sprintf(buf, "%u\n",
(data->alarms & (1 << 12)) && data->temp[index] == 127); (data->alarms & BIT(12)) && data->temp[index] == 127);
} }
static ssize_t set_temp_max(struct device *dev, static ssize_t set_temp_max(struct device *dev,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment