Commit 696ea472 authored by Changli Gao's avatar Changli Gao Committed by David S. Miller

llc: avoid skb_clone() if there is only one handler

Signed-off-by: default avatarChangli Gao <xiaosuo@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 98507672
...@@ -181,25 +181,26 @@ int llc_rcv(struct sk_buff *skb, struct net_device *dev, ...@@ -181,25 +181,26 @@ int llc_rcv(struct sk_buff *skb, struct net_device *dev,
* LLC functionality * LLC functionality
*/ */
rcv = rcu_dereference(sap->rcv_func); rcv = rcu_dereference(sap->rcv_func);
dest = llc_pdu_type(skb);
if (unlikely(!dest || !llc_type_handlers[dest - 1])) {
if (rcv)
rcv(skb, dev, pt, orig_dev);
else
kfree_skb(skb);
} else {
if (rcv) { if (rcv) {
struct sk_buff *cskb = skb_clone(skb, GFP_ATOMIC); struct sk_buff *cskb = skb_clone(skb, GFP_ATOMIC);
if (cskb) if (cskb)
rcv(cskb, dev, pt, orig_dev); rcv(cskb, dev, pt, orig_dev);
} }
dest = llc_pdu_type(skb);
if (unlikely(!dest || !llc_type_handlers[dest - 1]))
goto drop_put;
llc_type_handlers[dest - 1](sap, skb); llc_type_handlers[dest - 1](sap, skb);
out_put: }
llc_sap_put(sap); llc_sap_put(sap);
out: out:
return 0; return 0;
drop: drop:
kfree_skb(skb); kfree_skb(skb);
goto out; goto out;
drop_put:
kfree_skb(skb);
goto out_put;
handle_station: handle_station:
if (!llc_station_handler) if (!llc_station_handler)
goto drop; goto drop;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment