Commit 69712e92 authored by Max Filippov's avatar Max Filippov Committed by John W. Linville

p54spi: cosmetic fixes: use even byte count in SPI write; drop unused interrupt status read

When SPI write of odd length is requested, p54spi_write splits it
into two parts: one for all data, except the last byte, and one
for last byte and padding byte. Unfortunately, the length of
first part is not amended. It works because all meaningful bytes
have proper value and the last byte of odd length SPI write
transaction is ignored.

p54spi_work has dummy HOST_INTERRUPTS register read at the end.
Drop it, as its result is not used and it has no side effects.
Signed-off-by: default avatarMax Filippov <jcmvbkbc@gmail.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 210dd1bb
...@@ -96,7 +96,7 @@ static void p54spi_spi_write(struct p54s_priv *priv, u8 address, ...@@ -96,7 +96,7 @@ static void p54spi_spi_write(struct p54s_priv *priv, u8 address,
spi_message_add_tail(&t[0], &m); spi_message_add_tail(&t[0], &m);
t[1].tx_buf = buf; t[1].tx_buf = buf;
t[1].len = len; t[1].len = len & ~1;
spi_message_add_tail(&t[1], &m); spi_message_add_tail(&t[1], &m);
if (len % 2) { if (len % 2) {
...@@ -541,11 +541,6 @@ static void p54spi_work(struct work_struct *work) ...@@ -541,11 +541,6 @@ static void p54spi_work(struct work_struct *work)
} }
ret = p54spi_wq_tx(priv); ret = p54spi_wq_tx(priv);
if (ret < 0)
goto out;
ints = p54spi_read32(priv, SPI_ADRS_HOST_INTERRUPTS);
out: out:
mutex_unlock(&priv->mutex); mutex_unlock(&priv->mutex);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment