Commit 6bdf5168 authored by Yang Jihong's avatar Yang Jihong Committed by Arnaldo Carvalho de Melo

perf sched timehist: Fix missing free of session in perf_sched__timehist()

When perf_time__parse_str() fails in perf_sched__timehist(),
need to free session that was previously created, fix it.

Fixes: 853b7407 ("perf sched timehist: Add option to specify time window of interest")
Signed-off-by: default avatarYang Jihong <yangjihong@bytedance.com>
Acked-by: default avatarNamhyung Kim <namhyung@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: David Ahern <dsa@cumulusnetworks.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/20240806023533.1316348-1-yangjihong@bytedance.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent b53f20b3
...@@ -3120,7 +3120,8 @@ static int perf_sched__timehist(struct perf_sched *sched) ...@@ -3120,7 +3120,8 @@ static int perf_sched__timehist(struct perf_sched *sched)
if (perf_time__parse_str(&sched->ptime, sched->time_str) != 0) { if (perf_time__parse_str(&sched->ptime, sched->time_str) != 0) {
pr_err("Invalid time string\n"); pr_err("Invalid time string\n");
return -EINVAL; err = -EINVAL;
goto out;
} }
if (timehist_check_attr(sched, evlist) != 0) if (timehist_check_attr(sched, evlist) != 0)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment