Commit 6ccc3abd authored by huajun li's avatar huajun li Committed by David S. Miller

net/flow: Fix potential memory leak

While preparing net flow caches, once a fail may cause potential
memory leak , fix it.
Signed-off-by: default avatarHuajun Li <huajun.li.lee@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e6f8aa9b
...@@ -413,7 +413,7 @@ static int __init flow_cache_init(struct flow_cache *fc) ...@@ -413,7 +413,7 @@ static int __init flow_cache_init(struct flow_cache *fc)
for_each_online_cpu(i) { for_each_online_cpu(i) {
if (flow_cache_cpu_prepare(fc, i)) if (flow_cache_cpu_prepare(fc, i))
return -ENOMEM; goto err;
} }
fc->hotcpu_notifier = (struct notifier_block){ fc->hotcpu_notifier = (struct notifier_block){
.notifier_call = flow_cache_cpu, .notifier_call = flow_cache_cpu,
...@@ -426,6 +426,18 @@ static int __init flow_cache_init(struct flow_cache *fc) ...@@ -426,6 +426,18 @@ static int __init flow_cache_init(struct flow_cache *fc)
add_timer(&fc->rnd_timer); add_timer(&fc->rnd_timer);
return 0; return 0;
err:
for_each_possible_cpu(i) {
struct flow_cache_percpu *fcp = per_cpu_ptr(fc->percpu, i);
kfree(fcp->hash_table);
fcp->hash_table = NULL;
}
free_percpu(fc->percpu);
fc->percpu = NULL;
return -ENOMEM;
} }
static int __init flow_cache_init_global(void) static int __init flow_cache_init_global(void)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment