Commit 6ccdf067 authored by Gabe Teeger's avatar Gabe Teeger Committed by Alex Deucher

drm/amd/display: Cleanup PSR flag

[Why]
enable_sw_cntl_psr flag is not needed.
For PSR1 and PSR2, we should be passing
dirty rectangle and cursor updates to FW
regardless of enable_sw_cntl_psr flag.

[How]
Remove enable_sw_cntl_psr flag from driver.
Send cursor info and dirty rectagle status to
dmub only in the case of dcn31 and above.
Reviewed-by: default avatarAnthony Koo <Anthony.Koo@amd.com>
Reviewed-by: default avatarRobin Chen <robin.chen@amd.com>
Acked-by: default avatarBrian Chang <Brian.Chang@amd.com>
Signed-off-by: default avatarGabe Teeger <gabe.teeger@amd.com>
Tested-by: default avatarDaniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 4e65878d
...@@ -3113,11 +3113,9 @@ static void commit_planes_do_stream_update(struct dc *dc, ...@@ -3113,11 +3113,9 @@ static void commit_planes_do_stream_update(struct dc *dc,
static bool dc_dmub_should_send_dirty_rect_cmd(struct dc *dc, struct dc_stream_state *stream) static bool dc_dmub_should_send_dirty_rect_cmd(struct dc *dc, struct dc_stream_state *stream)
{ {
if (stream->link->psr_settings.psr_version == DC_PSR_VERSION_SU_1) if ((stream->link->psr_settings.psr_version == DC_PSR_VERSION_SU_1
return true; || stream->link->psr_settings.psr_version == DC_PSR_VERSION_1)
&& stream->ctx->dce_version >= DCN_VERSION_3_1)
if (stream->link->psr_settings.psr_version == DC_PSR_VERSION_1 &&
dc->debug.enable_sw_cntl_psr)
return true; return true;
return false; return false;
......
...@@ -827,7 +827,6 @@ struct dc_debug_options { ...@@ -827,7 +827,6 @@ struct dc_debug_options {
int crb_alloc_policy_min_disp_count; int crb_alloc_policy_min_disp_count;
bool disable_z10; bool disable_z10;
bool enable_z9_disable_interface; bool enable_z9_disable_interface;
bool enable_sw_cntl_psr;
union dpia_debug_options dpia_debug; union dpia_debug_options dpia_debug;
bool disable_fixed_vs_aux_timeout_wa; bool disable_fixed_vs_aux_timeout_wa;
bool force_disable_subvp; bool force_disable_subvp;
......
...@@ -3343,7 +3343,8 @@ static bool dcn10_dmub_should_update_cursor_data( ...@@ -3343,7 +3343,8 @@ static bool dcn10_dmub_should_update_cursor_data(
if (dcn10_can_pipe_disable_cursor(pipe_ctx)) if (dcn10_can_pipe_disable_cursor(pipe_ctx))
return false; return false;
if (pipe_ctx->stream->link->psr_settings.psr_version == DC_PSR_VERSION_SU_1 || pipe_ctx->stream->link->psr_settings.psr_version == DC_PSR_VERSION_1) if ((pipe_ctx->stream->link->psr_settings.psr_version == DC_PSR_VERSION_SU_1 || pipe_ctx->stream->link->psr_settings.psr_version == DC_PSR_VERSION_1)
&& pipe_ctx->stream->ctx->dce_version >= DCN_VERSION_3_1)
return true; return true;
return false; return false;
......
...@@ -889,7 +889,6 @@ static const struct dc_debug_options debug_defaults_drv = { ...@@ -889,7 +889,6 @@ static const struct dc_debug_options debug_defaults_drv = {
}, },
.disable_z10 = true, .disable_z10 = true,
.optimize_edp_link_rate = true, .optimize_edp_link_rate = true,
.enable_sw_cntl_psr = true,
.enable_z9_disable_interface = true, /* Allow support for the PMFW interface for disable Z9*/ .enable_z9_disable_interface = true, /* Allow support for the PMFW interface for disable Z9*/
.dml_hostvm_override = DML_HOSTVM_OVERRIDE_FALSE, .dml_hostvm_override = DML_HOSTVM_OVERRIDE_FALSE,
}; };
......
...@@ -911,7 +911,6 @@ static const struct dc_debug_options debug_defaults_drv = { ...@@ -911,7 +911,6 @@ static const struct dc_debug_options debug_defaults_drv = {
} }
}, },
.optimize_edp_link_rate = true, .optimize_edp_link_rate = true,
.enable_sw_cntl_psr = true,
.seamless_boot_odm_combine = true .seamless_boot_odm_combine = true
}; };
......
...@@ -886,7 +886,6 @@ static const struct dc_debug_options debug_defaults_drv = { ...@@ -886,7 +886,6 @@ static const struct dc_debug_options debug_defaults_drv = {
} }
}, },
.optimize_edp_link_rate = true, .optimize_edp_link_rate = true,
.enable_sw_cntl_psr = true,
.psr_power_use_phy_fsm = 0, .psr_power_use_phy_fsm = 0,
}; };
......
...@@ -886,7 +886,6 @@ static const struct dc_debug_options debug_defaults_drv = { ...@@ -886,7 +886,6 @@ static const struct dc_debug_options debug_defaults_drv = {
} }
}, },
.optimize_edp_link_rate = true, .optimize_edp_link_rate = true,
.enable_sw_cntl_psr = true,
}; };
static const struct dc_debug_options debug_defaults_diags = { static const struct dc_debug_options debug_defaults_diags = {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment