Commit 6d2d49d2 authored by Thomas Gleixner's avatar Thomas Gleixner

x86/x2apic: Use state information for disable

Use the state information to simplify the disable logic further.
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Acked-by: default avatarBorislav Petkov <bp@alien8.de>
Cc: Jiang Liu <jiang.liu@linux.intel.com>
Cc: Joerg Roedel <joro@8bytes.org>
Cc: Tony Luck <tony.luck@intel.com>
Link: http://lkml.kernel.org/r/20150115211703.209387598@linutronix.deSigned-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
parent 659006bf
...@@ -1547,26 +1547,20 @@ void x2apic_setup(void) ...@@ -1547,26 +1547,20 @@ void x2apic_setup(void)
static __init void x2apic_disable(void) static __init void x2apic_disable(void)
{ {
u64 msr; u32 x2apic_id;
if (!cpu_has_x2apic)
return;
rdmsrl(MSR_IA32_APICBASE, msr);
if (msr & X2APIC_ENABLE) {
u32 x2apic_id = read_apic_id();
if (x2apic_id >= 255) if (x2apic_state != X2APIC_ON)
panic("Cannot disable x2apic, id: %08x\n", x2apic_id); goto out;
__x2apic_disable(); x2apic_id = read_apic_id();
if (x2apic_id >= 255)
x2apic_mode = 0; panic("Cannot disable x2apic, id: %08x\n", x2apic_id);
register_lapic_address(mp_lapic_addr);
}
__x2apic_disable();
register_lapic_address(mp_lapic_addr);
out:
x2apic_state = X2APIC_DISABLED; x2apic_state = X2APIC_DISABLED;
x2apic_mode = 0;
} }
static __init void x2apic_enable(void) static __init void x2apic_enable(void)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment