Commit 6d4abf1c authored by Wei Yongjun's avatar Wei Yongjun Committed by Greg Kroah-Hartman

staging: axis-fifo: fix return value check in axis_fifo_probe()

In case of error, the function device_create() returns ERR_PTR() and
never returns NULL. The NULL test in the return value check should be
replaced with IS_ERR().

Fixes: 4a965c5f ("staging: add driver for Xilinx AXI-Stream FIFO v4.1 IP core")
Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 758c579e
...@@ -1006,10 +1006,10 @@ static int axis_fifo_probe(struct platform_device *pdev) ...@@ -1006,10 +1006,10 @@ static int axis_fifo_probe(struct platform_device *pdev)
/* create driver file */ /* create driver file */
fifo->device = device_create(axis_fifo_driver_class, NULL, fifo->devt, fifo->device = device_create(axis_fifo_driver_class, NULL, fifo->devt,
NULL, device_name); NULL, device_name);
if (!fifo->device) { if (IS_ERR(fifo->device)) {
dev_err(fifo->dt_device, dev_err(fifo->dt_device,
"couldn't create driver file\n"); "couldn't create driver file\n");
rc = -ENOMEM; rc = PTR_ERR(fifo->device);
goto err_chrdev_region; goto err_chrdev_region;
} }
dev_set_drvdata(fifo->device, fifo); dev_set_drvdata(fifo->device, fifo);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment