Commit 6dc88895 authored by Jeff Layton's avatar Jeff Layton Committed by J. Bruce Fields

nfsd: remove unneeded spinlock in nfsd_cache_update

The locking rules for cache entries say that locking the cache_lock
isn't needed if you're just touching the current entry. Earlier
in this function we set rp->c_state to RC_UNUSED without any locking,
so I believe it's ok to do the same here.
Signed-off-by: default avatarJeff Layton <jlayton@redhat.com>
Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
parent 7b9e8522
...@@ -286,9 +286,7 @@ nfsd_cache_update(struct svc_rqst *rqstp, int cachetype, __be32 *statp) ...@@ -286,9 +286,7 @@ nfsd_cache_update(struct svc_rqst *rqstp, int cachetype, __be32 *statp)
cachv = &rp->c_replvec; cachv = &rp->c_replvec;
cachv->iov_base = kmalloc(len << 2, GFP_KERNEL); cachv->iov_base = kmalloc(len << 2, GFP_KERNEL);
if (!cachv->iov_base) { if (!cachv->iov_base) {
spin_lock(&cache_lock);
rp->c_state = RC_UNUSED; rp->c_state = RC_UNUSED;
spin_unlock(&cache_lock);
return; return;
} }
cachv->iov_len = len << 2; cachv->iov_len = len << 2;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment