Commit 6dca9360 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by David S. Miller

flow_offload: use struct_size() in kzalloc()

One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct foo {
   int stuff;
   struct boo entry[];
};

instance = kzalloc(sizeof(struct foo) + count * sizeof(struct boo), GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper:

instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL);

This code was detected with the help of Coccinelle.
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 22942498
...@@ -7,8 +7,7 @@ struct flow_rule *flow_rule_alloc(unsigned int num_actions) ...@@ -7,8 +7,7 @@ struct flow_rule *flow_rule_alloc(unsigned int num_actions)
{ {
struct flow_rule *rule; struct flow_rule *rule;
rule = kzalloc(sizeof(struct flow_rule) + rule = kzalloc(struct_size(rule, action.entries, num_actions),
sizeof(struct flow_action_entry) * num_actions,
GFP_KERNEL); GFP_KERNEL);
if (!rule) if (!rule)
return NULL; return NULL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment