Commit 6e12ea46 authored by Andi Kleen's avatar Andi Kleen Committed by Greg Kroah-Hartman

USB-BKL: Remove lock_kernel in usbfs update_sb()

The code this is attempting to lock against does not use the BKL,
so it's not needed.

Most likely this code is still broken/racy (Al Viro also thinks so),
but removing the BKL should not make it worse than before.
Signed-off-by: default avatarAndi Kleen <ak@linux.intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 16f76a76
...@@ -265,13 +265,9 @@ static int remount(struct super_block *sb, int *flags, char *data) ...@@ -265,13 +265,9 @@ static int remount(struct super_block *sb, int *flags, char *data)
return -EINVAL; return -EINVAL;
} }
lock_kernel();
if (usbfs_mount && usbfs_mount->mnt_sb) if (usbfs_mount && usbfs_mount->mnt_sb)
update_sb(usbfs_mount->mnt_sb); update_sb(usbfs_mount->mnt_sb);
unlock_kernel();
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment