Commit 6e28aaab authored by Nishka Dasgupta's avatar Nishka Dasgupta Committed by Linus Walleij

pinctrl: rk805: Make structures constant

Static structures rk805_pinctrl_desc and rk805_gpio_chip, of types
gpio_chip and pinctrl_desc respectively, are not used except to be
copied into the fields of a different variable. Hence make
rk805_pinctrl_desc and rk805_gpio_chip both constant to protect them
from unintended modification.
Issue found with Coccinelle.
Signed-off-by: default avatarNishka Dasgupta <nishkadg.linux@gmail.com>
Link: https://lore.kernel.org/r/20190819075757.1753-1-nishkadg.linux@gmail.comSigned-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent a4873acc
...@@ -197,7 +197,7 @@ static int rk805_gpio_get_direction(struct gpio_chip *chip, unsigned int offset) ...@@ -197,7 +197,7 @@ static int rk805_gpio_get_direction(struct gpio_chip *chip, unsigned int offset)
return !(val & pci->pin_cfg[offset].dir_msk); return !(val & pci->pin_cfg[offset].dir_msk);
} }
static struct gpio_chip rk805_gpio_chip = { static const struct gpio_chip rk805_gpio_chip = {
.label = "rk805-gpio", .label = "rk805-gpio",
.request = gpiochip_generic_request, .request = gpiochip_generic_request,
.free = gpiochip_generic_free, .free = gpiochip_generic_free,
...@@ -404,7 +404,7 @@ static const struct pinconf_ops rk805_pinconf_ops = { ...@@ -404,7 +404,7 @@ static const struct pinconf_ops rk805_pinconf_ops = {
.pin_config_set = rk805_pinconf_set, .pin_config_set = rk805_pinconf_set,
}; };
static struct pinctrl_desc rk805_pinctrl_desc = { static const struct pinctrl_desc rk805_pinctrl_desc = {
.name = "rk805-pinctrl", .name = "rk805-pinctrl",
.pctlops = &rk805_pinctrl_ops, .pctlops = &rk805_pinctrl_ops,
.pmxops = &rk805_pinmux_ops, .pmxops = &rk805_pinmux_ops,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment