Commit 6e5d5791 authored by Yang Li's avatar Yang Li Committed by Bartosz Golaszewski

gpiolib: acpi: Add missing IRQF_ONESHOT

fixed the following coccicheck:
./drivers/gpio/gpiolib-acpi.c:176:7-27: ERROR: Threaded IRQ with no
primary handler requested without IRQF_ONESHOT

Make sure threaded IRQs without a primary handler are always request
with IRQF_ONESHOT
Reported-by: default avatarAbaci Robot <abaci@linux.alibaba.com>
Signed-off-by: default avatarYang Li <yang.lee@linux.alibaba.com>
Acked-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
parent cf25ef6b
...@@ -174,7 +174,7 @@ static void acpi_gpiochip_request_irq(struct acpi_gpio_chip *acpi_gpio, ...@@ -174,7 +174,7 @@ static void acpi_gpiochip_request_irq(struct acpi_gpio_chip *acpi_gpio,
int ret, value; int ret, value;
ret = request_threaded_irq(event->irq, NULL, event->handler, ret = request_threaded_irq(event->irq, NULL, event->handler,
event->irqflags, "ACPI:Event", event); event->irqflags | IRQF_ONESHOT, "ACPI:Event", event);
if (ret) { if (ret) {
dev_err(acpi_gpio->chip->parent, dev_err(acpi_gpio->chip->parent,
"Failed to setup interrupt handler for %d\n", "Failed to setup interrupt handler for %d\n",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment