Commit 6ef6386e authored by Marc Zyngier's avatar Marc Zyngier

irqchip/gic-v3: Loudly complain about the use of IRQ_TYPE_NONE

There is a huge number of broken device trees out there. Just
grepping through the tree for the use of IRQ_TYPE_NONE in conjunction
with the GIC is scary.

People just don't realise that IRQ_TYPE_NONE just doesn't exist, and
you just get whatever junk was there before. So let's make them aware
of the issue.
Signed-off-by: default avatarMarc Zyngier <marc.zyngier@arm.com>
parent 83a86fbb
...@@ -916,6 +916,9 @@ static int gic_irq_domain_translate(struct irq_domain *d, ...@@ -916,6 +916,9 @@ static int gic_irq_domain_translate(struct irq_domain *d,
} }
*type = fwspec->param[2] & IRQ_TYPE_SENSE_MASK; *type = fwspec->param[2] & IRQ_TYPE_SENSE_MASK;
/* Make it clear that broken DTs are... broken */
WARN_ON(*type == IRQ_TYPE_NONE);
return 0; return 0;
} }
...@@ -925,6 +928,8 @@ static int gic_irq_domain_translate(struct irq_domain *d, ...@@ -925,6 +928,8 @@ static int gic_irq_domain_translate(struct irq_domain *d,
*hwirq = fwspec->param[0]; *hwirq = fwspec->param[0];
*type = fwspec->param[1]; *type = fwspec->param[1];
WARN_ON(*type == IRQ_TYPE_NONE);
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment