Commit 6f26afc9 authored by Pavel Emelyanov's avatar Pavel Emelyanov Committed by Ben Hutchings

datagram: Factor out sk queue referencing

commit 4934b032 upstream.

This makes lines shorter and simplifies further patching.
Signed-off-by: default avatarPavel Emelyanov <xemul@parallels.com>
Acked-by: default avatarEric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
[bwh: Prerequisite of "net: Clone skb before setting peeked flag"]
Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
parent d6ded324
...@@ -180,18 +180,19 @@ struct sk_buff *__skb_recv_datagram(struct sock *sk, unsigned flags, ...@@ -180,18 +180,19 @@ struct sk_buff *__skb_recv_datagram(struct sock *sk, unsigned flags,
* However, this function was correct in any case. 8) * However, this function was correct in any case. 8)
*/ */
unsigned long cpu_flags; unsigned long cpu_flags;
struct sk_buff_head *queue = &sk->sk_receive_queue;
spin_lock_irqsave(&sk->sk_receive_queue.lock, cpu_flags); spin_lock_irqsave(&queue->lock, cpu_flags);
skb = skb_peek(&sk->sk_receive_queue); skb = skb_peek(queue);
if (skb) { if (skb) {
*peeked = skb->peeked; *peeked = skb->peeked;
if (flags & MSG_PEEK) { if (flags & MSG_PEEK) {
skb->peeked = 1; skb->peeked = 1;
atomic_inc(&skb->users); atomic_inc(&skb->users);
} else } else
__skb_unlink(skb, &sk->sk_receive_queue); __skb_unlink(skb, queue);
} }
spin_unlock_irqrestore(&sk->sk_receive_queue.lock, cpu_flags); spin_unlock_irqrestore(&queue->lock, cpu_flags);
if (skb) if (skb)
return skb; return skb;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment