drm/amd/display: Add missing static

After enable DRM_AMDGPU_WERROR, clang highlight multiple functions that
need to have `static`, and this commit address those issues and also
improve the indents.
Reviewed-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
Acked-by: Alan Liu <haoping.liu@amd.com>
Signed-off-by: Rodrigo Siqueira <rodrigo.siqueira@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

drivers/gpu/drm/amd/display/dc/basics/vector.c

@@ -50,8 +50,7 @@ bool dal_vector_construct(
 	return true;
 }
 
-static bool dal_vector_presized_costruct(
-	struct vector *vector,
+static bool dal_vector_presized_costruct(struct vector *vector,
 					 struct dc_context *ctx,
 					 uint32_t count,
 					 void *initial_value,

drivers/gpu/drm/amd/display/dc/bios/bios_parser.c

@@ -2593,8 +2593,7 @@ static struct integrated_info *bios_parser_create_integrated_info(
 	return NULL;
 }
 
-static enum bp_result update_slot_layout_info(
-	struct dc_bios *dcb,
+static enum bp_result update_slot_layout_info(struct dc_bios *dcb,
 					      unsigned int i,
 					      struct slot_layout_info *slot_layout_info,
 					      unsigned int record_offset)
@@ -2696,8 +2695,7 @@ static enum bp_result update_slot_layout_info(
 }
 
 
-static enum bp_result get_bracket_layout_record(
-	struct dc_bios *dcb,
+static enum bp_result get_bracket_layout_record(struct dc_bios *dcb,
 						unsigned int bracket_layout_id,
 						struct slot_layout_info *slot_layout_info)
 {

drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c

@@ -340,8 +340,7 @@ static struct atom_display_object_path_v2 *get_bios_object(
 }
 
 /* from graphics_object_id, find display path which includes the object_id */
-static struct atom_display_object_path_v3 *get_bios_object_from_path_v3(
-	struct bios_parser *bp,
+static struct atom_display_object_path_v3 *get_bios_object_from_path_v3(struct bios_parser *bp,
 									struct graphics_object_id id)
 {
 	unsigned int i;
@@ -521,8 +520,7 @@ static enum bp_result get_gpio_i2c_info(
 	return BP_RESULT_OK;
 }
 
-static struct atom_hpd_int_record *get_hpd_record_for_path_v3(
-	struct bios_parser *bp,
+static struct atom_hpd_int_record *get_hpd_record_for_path_v3(struct bios_parser *bp,
 							      struct atom_display_object_path_v3 *object)
 {
 	struct atom_common_record_header *header;
@@ -2175,8 +2173,7 @@ static struct atom_disp_connector_caps_record *get_disp_connector_caps_record(
 	return NULL;
 }
 
-static struct atom_connector_caps_record *get_connector_caps_record(
-	struct bios_parser *bp,
+static struct atom_connector_caps_record *get_connector_caps_record(struct bios_parser *bp,
 								    struct atom_display_object_path_v3 *object)
 {
 	struct atom_common_record_header *header;
@@ -2264,8 +2261,7 @@ static enum bp_result bios_parser_get_disp_connector_caps_info(
 	return BP_RESULT_OK;
 }
 
-static struct atom_connector_speed_record *get_connector_speed_cap_record(
-	struct bios_parser *bp,
+static struct atom_connector_speed_record *get_connector_speed_cap_record(struct bios_parser *bp,
 									  struct atom_display_object_path_v3 *object)
 {
 	struct atom_common_record_header *header;

drivers/gpu/drm/amd/display/dc/core/dc.c

@@ -1047,8 +1047,10 @@ static void disable_all_writeback_pipes_for_stream(
 		stream->writeback_info[i].wb_enabled = false;
 }
 
-static void apply_ctx_interdependent_lock(struct dc *dc, struct dc_state *context,
-					  struct dc_stream_state *stream, bool lock)
+static void apply_ctx_interdependent_lock(struct dc *dc,
+					  struct dc_state *context,
+					  struct dc_stream_state *stream,
+					  bool lock)
 {
 	int i;
 

drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c

@@ -187,6 +187,7 @@ static bool is_ycbcr709_limited_type(
 		ret = true;
 	return ret;
 }
+
 static enum dc_color_space_type get_color_space_type(enum dc_color_space color_space)
 {
 	enum dc_color_space_type type = COLOR_SPACE_RGB_TYPE;

drivers/gpu/drm/amd/display/dc/dce/dce_i2c_hw.c

@@ -442,8 +442,7 @@ struct dce_i2c_hw *acquire_i2c_hw_engine(
 	return dce_i2c_hw;
 }
 
-static enum i2c_channel_operation_result dce_i2c_hw_engine_wait_on_operation_result(
-	struct dce_i2c_hw *dce_i2c_hw,
+static enum i2c_channel_operation_result dce_i2c_hw_engine_wait_on_operation_result(struct dce_i2c_hw *dce_i2c_hw,
 										    uint32_t timeout,
 										    enum i2c_channel_operation_result expected_result)
 {
@@ -509,8 +508,7 @@ static uint32_t get_transaction_timeout_hw(
 	return period_timeout * num_of_clock_stretches;
 }
 
-static bool dce_i2c_hw_engine_submit_payload(
-	struct dce_i2c_hw *dce_i2c_hw,
+static bool dce_i2c_hw_engine_submit_payload(struct dce_i2c_hw *dce_i2c_hw,
 					     struct i2c_payload *payload,
 					     bool middle_of_transaction,
 					     uint32_t speed)

drivers/gpu/drm/amd/display/dc/dce/dce_i2c_sw.c

@@ -367,6 +367,7 @@ static bool dce_i2c_sw_engine_acquire_engine(
 
 	return true;
 }
+
 bool dce_i2c_engine_acquire_sw(
 	struct dce_i2c_sw *dce_i2c_sw,
 	struct ddc *ddc_handle)
@@ -392,11 +393,7 @@ bool dce_i2c_engine_acquire_sw(
 	return result;
 }
 
-
-
-
-static void dce_i2c_sw_engine_submit_channel_request(
-	struct dce_i2c_sw *engine,
+static void dce_i2c_sw_engine_submit_channel_request(struct dce_i2c_sw *engine,
 						     struct i2c_request_transaction_data *req)
 {
 	struct ddc *ddc = engine->ddc;
@@ -439,8 +436,7 @@ static void dce_i2c_sw_engine_submit_channel_request(
 		I2C_CHANNEL_OPERATION_FAILED;
 }
 
-static bool dce_i2c_sw_engine_submit_payload(
-	struct dce_i2c_sw *engine,
+static bool dce_i2c_sw_engine_submit_payload(struct dce_i2c_sw *engine,
 					     struct i2c_payload *payload,
 					     bool middle_of_transaction)
 {

drivers/gpu/drm/amd/display/dc/dcn21/dcn21_dccg.c

@@ -43,7 +43,7 @@
 #define DC_LOGGER \
 	dccg->ctx->logger
 
-void dccg21_update_dpp_dto(struct dccg *dccg, int dpp_inst, int req_dppclk)
+static void dccg21_update_dpp_dto(struct dccg *dccg, int dpp_inst, int req_dppclk)
 {
 	struct dcn_dccg *dccg_dcn = TO_DCN_DCCG(dccg);
 

drivers/gpu/drm/amd/display/dc/dcn21/dcn21_dccg.h

@@ -32,6 +32,5 @@ struct dccg *dccg21_create(
 	const struct dccg_shift *dccg_shift,
 	const struct dccg_mask *dccg_mask);
 
-void dccg21_update_dpp_dto(struct dccg *dccg, int dpp_inst, int req_dppclk);
 
 #endif /* __DCN21_DCCG_H__ */

drivers/gpu/drm/amd/display/dc/irq/dcn314/irq_service_dcn314.c

@@ -38,8 +38,7 @@
 
 #define DCN_BASE__INST0_SEG2                       0x000034C0
 
-static enum dc_irq_source to_dal_irq_source_dcn314(
-		struct irq_service *irq_service,
+static enum dc_irq_source to_dal_irq_source_dcn314(struct irq_service *irq_service,
 						   uint32_t src_id,
 						   uint32_t ext_id)
 {