Commit 6f515b66 authored by Arnaud Ferraris's avatar Arnaud Ferraris Committed by Heiko Stuebner

arm64: dts: rockchip: fix input enable pinconf on rk3399

When the input enable pinconf was introduced, a default drive-strength
value of 2 was set for the pull up/down configs. However, this parameter
is unneeded when configuring the pin as input, and having a single
hardcoded value here is actually harmful: GPIOs on the RK3399 have
various same drive-strength capabilities depending on the bank and port
they belong to.

As an example, trying to configure the GPIO4_PD3 pin as an input with
pull-up enabled fails with the following output:

  [   10.706542] rockchip-pinctrl pinctrl: unsupported driver strength 2
  [   10.713661] rockchip-pinctrl pinctrl: pin_config_set op failed for pin 155

(acceptable drive-strength values for this pin being 3, 6, 9 and 12)

Let's drop the drive-strength property from all input pinconfs in order
to solve this issue.

Fixes: ec48c3e8 ("arm64: dts: rockchip: add an input enable pinconf to rk3399")
Signed-off-by: default avatarArnaud Ferraris <arnaud.ferraris@collabora.com>
Reviewed-by: default avatarCaleb Connolly <kc@postmarketos.org>
Link: https://lore.kernel.org/r/20221215101947.254896-1-arnaud.ferraris@collabora.comSigned-off-by: default avatarHeiko Stuebner <heiko@sntech.de>
parent 80422339
...@@ -2241,13 +2241,11 @@ pcfg_input_enable: pcfg-input-enable { ...@@ -2241,13 +2241,11 @@ pcfg_input_enable: pcfg-input-enable {
pcfg_input_pull_up: pcfg-input-pull-up { pcfg_input_pull_up: pcfg-input-pull-up {
input-enable; input-enable;
bias-pull-up; bias-pull-up;
drive-strength = <2>;
}; };
pcfg_input_pull_down: pcfg-input-pull-down { pcfg_input_pull_down: pcfg-input-pull-down {
input-enable; input-enable;
bias-pull-down; bias-pull-down;
drive-strength = <2>;
}; };
clock { clock {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment