Commit 6f65540b authored by Chia-Wei Wang's avatar Chia-Wei Wang Committed by Corey Minyard

ipmi: kcs: aspeed: Update port address comments

Remove AST_usrGuide_KCS.pdf as it is no longer maintained.

Add more descriptions as the driver now supports the I/O
address configurations for both the KCS Data and Cmd/Status
interface registers.
Signed-off-by: default avatarChia-Wei Wang <chiawei_wang@aspeedtech.com>
Message-Id: <20220920020333.601-1-chiawei_wang@aspeedtech.com>
[I don't like removing documentation, but the document in question
 was a personal note by an employee and nothing official and not
 necessarily guaranteed to be accurate in the future.  So go
 ahead and remove it.]
Signed-off-by: default avatarCorey Minyard <cminyard@mvista.com>
parent ec7174f6
...@@ -207,17 +207,24 @@ static void aspeed_kcs_updateb(struct kcs_bmc_device *kcs_bmc, u32 reg, u8 mask, ...@@ -207,17 +207,24 @@ static void aspeed_kcs_updateb(struct kcs_bmc_device *kcs_bmc, u32 reg, u8 mask,
} }
/* /*
* AST_usrGuide_KCS.pdf * We note D for Data, and C for Cmd/Status, default rules are
* 2. Background: *
* we note D for Data, and C for Cmd/Status, default rules are * 1. Only the D address is given:
* A. KCS1 / KCS2 ( D / C:X / X+4 ) * A. KCS1/KCS2 (D/C: X/X+4)
* D / C : CA0h / CA4h * D/C: CA0h/CA4h
* D / C : CA8h / CACh * D/C: CA8h/CACh
* B. KCS3 ( D / C:XX2h / XX3h ) * B. KCS3 (D/C: XX2/XX3h)
* D / C : CA2h / CA3h * D/C: CA2h/CA3h
* D / C : CB2h / CB3h * C. KCS4 (D/C: X/X+1)
* C. KCS4 * D/C: CA4h/CA5h
* D / C : CA4h / CA5h *
* 2. Both the D/C addresses are given:
* A. KCS1/KCS2/KCS4 (D/C: X/Y)
* D/C: CA0h/CA1h
* D/C: CA8h/CA9h
* D/C: CA4h/CA5h
* B. KCS3 (D/C: XX2/XX3h)
* D/C: CA2h/CA3h
*/ */
static int aspeed_kcs_set_address(struct kcs_bmc_device *kcs_bmc, u32 addrs[2], int nr_addrs) static int aspeed_kcs_set_address(struct kcs_bmc_device *kcs_bmc, u32 addrs[2], int nr_addrs)
{ {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment