staging: comedi: pcmuio: fix possible NULL deref on detach

commit 2fd2bdfc upstream.

pcmuio_detach() is called by the comedi core even if pcmuio_attach()
returned an error, so `dev->private` might be `NULL`.  Check for that
before dereferencing it.

Also, as pointed out by Dan Carpenter, there is no need to check the
pointer passed to `kfree()` is non-NULL, so remove that check.
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/staging/comedi/drivers/pcmuio.c

@@ -464,13 +464,13 @@ static int pcmuio_detach(struct comedi_device *dev)
 	if (dev->iobase)
 		release_region(dev->iobase, ASIC_IOSIZE * thisboard->num_asics);
 
+	if (devpriv) {
 		for (i = 0; i < MAX_ASICS; ++i) {
 			if (devpriv->asics[i].irq)
 				free_irq(devpriv->asics[i].irq, dev);
 		}
-
-	if (devpriv && devpriv->sprivs)
 		kfree(devpriv->sprivs);
+	}
 
 	return 0;
 }