Commit 713baf3d authored by Colin Ian King's avatar Colin Ian King Committed by Marcel Holtmann

Bluetooth: increase BTNAMSIZ to 21 chars to fix potential buffer overflow

An earlier commit replaced using batostr to using %pMR sprintf for the
construction of session->name. Static analysis detected that this new
method can use a total of 21 characters (including the trailing '\0')
so we need to increase the BTNAMSIZ from 18 to 21 to fix potential
buffer overflows.

Addresses-Coverity: ("Out-of-bounds write")
Fixes: fcb73338 ("Bluetooth: Use %pMR in sprintf/seq_printf instead of batostr")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
parent 6eefec4a
...@@ -26,7 +26,7 @@ ...@@ -26,7 +26,7 @@
#include <linux/types.h> #include <linux/types.h>
#include <net/bluetooth/bluetooth.h> #include <net/bluetooth/bluetooth.h>
#define BTNAMSIZ 18 #define BTNAMSIZ 21
/* CMTP ioctl defines */ /* CMTP ioctl defines */
#define CMTPCONNADD _IOW('C', 200, int) #define CMTPCONNADD _IOW('C', 200, int)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment