Commit 71e03f10 authored by Amitoj Kaur Chawla's avatar Amitoj Kaur Chawla Committed by Greg Kroah-Hartman

staging: fbtft: Remove unnecessary spi_set_drvdata()

Unnecessary spi_set_drvdata() has been removed since the driver
core clears the driver data to NULL after device release or on
probe failure. There is no need to manually clear the device
driver data to NULL.

The Coccinelle semantic patch used to make this change is as follows:
@@
struct spi_device *spi;
@@
- spi_set_drvdata(spi, NULL);
// </smpl>

Due to this removal, variable `spi` was unused so dropped `spi`
Signed-off-by: default avatarAmitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3589d3c9
...@@ -985,8 +985,6 @@ int fbtft_register_framebuffer(struct fb_info *fb_info) ...@@ -985,8 +985,6 @@ int fbtft_register_framebuffer(struct fb_info *fb_info)
reg_fail: reg_fail:
if (par->fbtftops.unregister_backlight) if (par->fbtftops.unregister_backlight)
par->fbtftops.unregister_backlight(par); par->fbtftops.unregister_backlight(par);
if (spi)
spi_set_drvdata(spi, NULL);
return ret; return ret;
} }
...@@ -1004,10 +1002,7 @@ EXPORT_SYMBOL(fbtft_register_framebuffer); ...@@ -1004,10 +1002,7 @@ EXPORT_SYMBOL(fbtft_register_framebuffer);
int fbtft_unregister_framebuffer(struct fb_info *fb_info) int fbtft_unregister_framebuffer(struct fb_info *fb_info)
{ {
struct fbtft_par *par = fb_info->par; struct fbtft_par *par = fb_info->par;
struct spi_device *spi = par->spi;
if (spi)
spi_set_drvdata(spi, NULL);
if (par->fbtftops.unregister_backlight) if (par->fbtftops.unregister_backlight)
par->fbtftops.unregister_backlight(par); par->fbtftops.unregister_backlight(par);
fbtft_sysfs_exit(par); fbtft_sysfs_exit(par);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment