Commit 7206b517 authored by Ville Syrjälä's avatar Ville Syrjälä

drm/i915/dsb: Pimp debug/error prints

Print the crtc/DSB id information to make it clear which DSB engine
we're talking about.
Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230118163040.29808-3-ville.syrjala@linux.intel.comReviewed-by: default avatarAnimesh Manna <animesh.manna@intel.com>
parent 1af546c2
...@@ -88,7 +88,8 @@ static bool assert_dsb_has_room(struct intel_dsb *dsb) ...@@ -88,7 +88,8 @@ static bool assert_dsb_has_room(struct intel_dsb *dsb)
/* each instruction is 2 dwords */ /* each instruction is 2 dwords */
return !drm_WARN(&i915->drm, dsb->free_pos > dsb->size - 2, return !drm_WARN(&i915->drm, dsb->free_pos > dsb->size - 2,
"DSB buffer overflow\n"); "[CRTC:%d:%s] DSB %d buffer overflow\n",
crtc->base.base.id, crtc->base.name, dsb->id);
} }
static bool is_dsb_busy(struct drm_i915_private *i915, enum pipe pipe, static bool is_dsb_busy(struct drm_i915_private *i915, enum pipe pipe,
...@@ -232,7 +233,8 @@ void intel_dsb_commit(struct intel_dsb *dsb) ...@@ -232,7 +233,8 @@ void intel_dsb_commit(struct intel_dsb *dsb)
return; return;
if (is_dsb_busy(dev_priv, pipe, dsb->id)) { if (is_dsb_busy(dev_priv, pipe, dsb->id)) {
drm_err(&dev_priv->drm, "DSB engine is busy.\n"); drm_err(&dev_priv->drm, "[CRTC:%d:%s] DSB %d is busy\n",
crtc->base.base.id, crtc->base.name, dsb->id);
goto reset; goto reset;
} }
...@@ -250,7 +252,8 @@ void intel_dsb_commit(struct intel_dsb *dsb) ...@@ -250,7 +252,8 @@ void intel_dsb_commit(struct intel_dsb *dsb)
if (wait_for(!is_dsb_busy(dev_priv, pipe, dsb->id), 1)) if (wait_for(!is_dsb_busy(dev_priv, pipe, dsb->id), 1))
drm_err(&dev_priv->drm, drm_err(&dev_priv->drm,
"Timed out waiting for DSB workload completion.\n"); "[CRTC:%d:%s] DSB %d timed out waiting for idle\n",
crtc->base.base.id, crtc->base.name, dsb->id);
reset: reset:
dsb->free_pos = 0; dsb->free_pos = 0;
...@@ -325,7 +328,8 @@ struct intel_dsb *intel_dsb_prepare(struct intel_crtc *crtc, ...@@ -325,7 +328,8 @@ struct intel_dsb *intel_dsb_prepare(struct intel_crtc *crtc,
kfree(dsb); kfree(dsb);
out: out:
drm_info_once(&i915->drm, drm_info_once(&i915->drm,
"DSB queue setup failed, will fallback to MMIO for display HW programming\n"); "[CRTC:%d:%s] DSB %d queue setup failed, will fallback to MMIO for display HW programming\n",
crtc->base.base.id, crtc->base.name, DSB1);
return NULL; return NULL;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment