Commit 722a0d22 authored by Andres Freund's avatar Andres Freund Committed by H. Peter Anvin

x86: Fix typo preventing msr_set/clear_bit from having an effect

Due to a typo the msr accessor function introduced in
22085a66 didn't have any lasting
effects because they accidentally wrote the old value back.

After c0a639ad this at the very least
this causes cpuid limits not to be lifted on some cpus leading to
missing capabilities for those.
Signed-off-by: default avatarAndres Freund <andres@anarazel.de>
Link: http://lkml.kernel.org/r/1399598957-7011-2-git-send-email-andres@anarazel.de
Cc: Borislav Petkov <bp@suse.de>
Signed-off-by: default avatarH. Peter Anvin <hpa@zytor.com>
parent 62187910
...@@ -76,7 +76,7 @@ static inline int __flip_bit(u32 msr, u8 bit, bool set) ...@@ -76,7 +76,7 @@ static inline int __flip_bit(u32 msr, u8 bit, bool set)
if (m1.q == m.q) if (m1.q == m.q)
return 0; return 0;
err = msr_write(msr, &m); err = msr_write(msr, &m1);
if (err) if (err)
return err; return err;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment