Commit 72673e86 authored by Yang Shi's avatar Yang Shi Committed by Linus Torvalds

mm: vmscan: use kvfree_rcu instead of call_rcu

Using kvfree_rcu() to free the old shrinker_maps instead of call_rcu().
We don't have to define a dedicated callback for call_rcu() anymore.

Link: https://lkml.kernel.org/r/20210311190845.9708-6-shy828301@gmail.comSigned-off-by: default avatarYang Shi <shy828301@gmail.com>
Acked-by: default avatarRoman Gushchin <guro@fb.com>
Acked-by: default avatarKirill Tkhai <ktkhai@virtuozzo.com>
Reviewed-by: default avatarShakeel Butt <shakeelb@google.com>
Cc: Dave Chinner <david@fromorbit.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent a2fb1261
...@@ -192,11 +192,6 @@ static inline int shrinker_map_size(int nr_items) ...@@ -192,11 +192,6 @@ static inline int shrinker_map_size(int nr_items)
return (DIV_ROUND_UP(nr_items, BITS_PER_LONG) * sizeof(unsigned long)); return (DIV_ROUND_UP(nr_items, BITS_PER_LONG) * sizeof(unsigned long));
} }
static void free_shrinker_map_rcu(struct rcu_head *head)
{
kvfree(container_of(head, struct memcg_shrinker_map, rcu));
}
static int expand_one_shrinker_map(struct mem_cgroup *memcg, static int expand_one_shrinker_map(struct mem_cgroup *memcg,
int size, int old_size) int size, int old_size)
{ {
...@@ -220,7 +215,7 @@ static int expand_one_shrinker_map(struct mem_cgroup *memcg, ...@@ -220,7 +215,7 @@ static int expand_one_shrinker_map(struct mem_cgroup *memcg,
memset((void *)new->map + old_size, 0, size - old_size); memset((void *)new->map + old_size, 0, size - old_size);
rcu_assign_pointer(pn->shrinker_map, new); rcu_assign_pointer(pn->shrinker_map, new);
call_rcu(&old->rcu, free_shrinker_map_rcu); kvfree_rcu(old, rcu);
} }
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment