Commit 737f644c authored by Lars-Peter Clausen's avatar Lars-Peter Clausen Committed by Dmitry Torokhov

Input: navpoint - pass correct pointer to free_irq()

free_irq() expects the same pointer that was passed to request_irq(),
otherwise the IRQ is not freed.

The issue was found using the following coccinelle script:

<smpl>
@r1@
type T;
T devid;
@@
request_irq(..., devid)

@r2@
type r1.T;
T devid;
position p;
@@
free_irq@p(..., devid)

@@
position p != r2.p;
@@
*free_irq@p(...)
</smpl>
Signed-off-by: default avatarLars-Peter Clausen <lars@metafoo.de>
Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent 139097a0
...@@ -287,7 +287,7 @@ static int navpoint_probe(struct platform_device *pdev) ...@@ -287,7 +287,7 @@ static int navpoint_probe(struct platform_device *pdev)
return 0; return 0;
err_free_irq: err_free_irq:
free_irq(ssp->irq, &pdev->dev); free_irq(ssp->irq, navpoint);
err_free_mem: err_free_mem:
input_free_device(input); input_free_device(input);
kfree(navpoint); kfree(navpoint);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment