Commit 7396a5b9 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Tzung-Bi Shih

platform/chrome/wilco_ec: telemetry: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230927081040.2198742-13-u.kleine-koenig@pengutronix.deSigned-off-by: default avatarTzung-Bi Shih <tzungbi@kernel.org>
parent 1fca58f3
...@@ -400,20 +400,18 @@ static int telem_device_probe(struct platform_device *pdev) ...@@ -400,20 +400,18 @@ static int telem_device_probe(struct platform_device *pdev)
return 0; return 0;
} }
static int telem_device_remove(struct platform_device *pdev) static void telem_device_remove(struct platform_device *pdev)
{ {
struct telem_device_data *dev_data = platform_get_drvdata(pdev); struct telem_device_data *dev_data = platform_get_drvdata(pdev);
cdev_device_del(&dev_data->cdev, &dev_data->dev); cdev_device_del(&dev_data->cdev, &dev_data->dev);
ida_simple_remove(&telem_ida, MINOR(dev_data->dev.devt)); ida_simple_remove(&telem_ida, MINOR(dev_data->dev.devt));
put_device(&dev_data->dev); put_device(&dev_data->dev);
return 0;
} }
static struct platform_driver telem_driver = { static struct platform_driver telem_driver = {
.probe = telem_device_probe, .probe = telem_device_probe,
.remove = telem_device_remove, .remove_new = telem_device_remove,
.driver = { .driver = {
.name = DRV_NAME, .name = DRV_NAME,
}, },
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment