Commit 73ea73af authored by Roy Luo's avatar Roy Luo Committed by Greg Kroah-Hartman

USB: gadget: core: adjust uevent timing on gadget unbind

The KOBJ_CHANGE uevent is sent before gadget unbind is actually
executed, resulting in inaccurate uevent emitted at incorrect timing
(the uevent would have USB_UDC_DRIVER variable set while it would
soon be removed).
Move the KOBJ_CHANGE uevent to the end of the unbind function so that
uevent is sent only after the change has been made.

Fixes: 2ccea03a ("usb: gadget: introduce UDC Class")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarRoy Luo <royluo@google.com>
Link: https://lore.kernel.org/r/20231128221756.2591158-1-royluo@google.comSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 33cc938e
...@@ -1646,8 +1646,6 @@ static void gadget_unbind_driver(struct device *dev) ...@@ -1646,8 +1646,6 @@ static void gadget_unbind_driver(struct device *dev)
dev_dbg(&udc->dev, "unbinding gadget driver [%s]\n", driver->function); dev_dbg(&udc->dev, "unbinding gadget driver [%s]\n", driver->function);
kobject_uevent(&udc->dev.kobj, KOBJ_CHANGE);
udc->allow_connect = false; udc->allow_connect = false;
cancel_work_sync(&udc->vbus_work); cancel_work_sync(&udc->vbus_work);
mutex_lock(&udc->connect_lock); mutex_lock(&udc->connect_lock);
...@@ -1667,6 +1665,8 @@ static void gadget_unbind_driver(struct device *dev) ...@@ -1667,6 +1665,8 @@ static void gadget_unbind_driver(struct device *dev)
driver->is_bound = false; driver->is_bound = false;
udc->driver = NULL; udc->driver = NULL;
mutex_unlock(&udc_lock); mutex_unlock(&udc_lock);
kobject_uevent(&udc->dev.kobj, KOBJ_CHANGE);
} }
/* ------------------------------------------------------------------------- */ /* ------------------------------------------------------------------------- */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment