Commit 74905e3d authored by Paolo Bonzini's avatar Paolo Bonzini

KVM: nSVM: clarify recalc_intercepts() wrt CR8

The mysterious comment "We only want the cr8 intercept bits of L1"
dates back to basically the introduction of nested SVM, back when
the handling of "less typical" hypervisors was very haphazard.
With the development of kvm-unit-tests for interrupt handling,
the same code grew another vmcb_clr_intercept for the interrupt
window (VINTR) vmexit, this time with a comment that is at least
decent.

It turns out however that the same comment applies to the CR8 write
intercept, which is also a "recheck if an interrupt should be
injected" intercept.  The CR8 read intercept instead has not
been used by KVM for 14 years (commit 649d6864, "KVM: SVM:
sync TPR value to V_TPR field in the VMCB"), so do not bother
clearing it and let one comment describe both CR8 write and VINTR
handling.
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent b7bfaa76
...@@ -138,15 +138,13 @@ void recalc_intercepts(struct vcpu_svm *svm) ...@@ -138,15 +138,13 @@ void recalc_intercepts(struct vcpu_svm *svm)
c->intercepts[i] = h->intercepts[i]; c->intercepts[i] = h->intercepts[i];
if (g->int_ctl & V_INTR_MASKING_MASK) { if (g->int_ctl & V_INTR_MASKING_MASK) {
/* We only want the cr8 intercept bits of L1 */
vmcb_clr_intercept(c, INTERCEPT_CR8_READ);
vmcb_clr_intercept(c, INTERCEPT_CR8_WRITE);
/* /*
* Once running L2 with HF_VINTR_MASK, EFLAGS.IF does not * Once running L2 with HF_VINTR_MASK, EFLAGS.IF and CR8
* affect any interrupt we may want to inject; therefore, * does not affect any interrupt we may want to inject;
* interrupt window vmexits are irrelevant to L0. * therefore, writes to CR8 are irrelevant to L0, as are
* interrupt window vmexits.
*/ */
vmcb_clr_intercept(c, INTERCEPT_CR8_WRITE);
vmcb_clr_intercept(c, INTERCEPT_VINTR); vmcb_clr_intercept(c, INTERCEPT_VINTR);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment