Commit 74bfc129 authored by Liang Zhen's avatar Liang Zhen Committed by Greg Kroah-Hartman

staging: lustre: libcfs: use break in switch options for libcfs_ioctl_handle

Instead of just returning for each switch condition use a break.
Signed-off-by: default avatarLiang Zhen <liang.zhen@intel.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5435
Reviewed-on: http://review.whamcloud.com/11313Reviewed-by: default avatarBobi Jam <bobijam@gmail.com>
Reviewed-by: default avatarJohann Lombardi <johann.lombardi@intel.com>
Reviewed-by: default avatarOleg Drokin <oleg.drokin@intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ae664e82
...@@ -116,7 +116,7 @@ static int libcfs_ioctl_handle(struct cfs_psdev_file *pfile, unsigned long cmd, ...@@ -116,7 +116,7 @@ static int libcfs_ioctl_handle(struct cfs_psdev_file *pfile, unsigned long cmd,
void __user *arg, struct libcfs_ioctl_hdr *hdr) void __user *arg, struct libcfs_ioctl_hdr *hdr)
{ {
struct libcfs_ioctl_data *data = NULL; struct libcfs_ioctl_data *data = NULL;
int err = -EINVAL; int err = 0;
/* /*
* The libcfs_ioctl_data_adjust() function performs adjustment * The libcfs_ioctl_data_adjust() function performs adjustment
...@@ -134,7 +134,7 @@ static int libcfs_ioctl_handle(struct cfs_psdev_file *pfile, unsigned long cmd, ...@@ -134,7 +134,7 @@ static int libcfs_ioctl_handle(struct cfs_psdev_file *pfile, unsigned long cmd,
switch (cmd) { switch (cmd) {
case IOC_LIBCFS_CLEAR_DEBUG: case IOC_LIBCFS_CLEAR_DEBUG:
libcfs_debug_clear_buffer(); libcfs_debug_clear_buffer();
return 0; break;
/* /*
* case IOC_LIBCFS_PANIC: * case IOC_LIBCFS_PANIC:
* Handled in arch/cfs_module.c * Handled in arch/cfs_module.c
...@@ -144,7 +144,7 @@ static int libcfs_ioctl_handle(struct cfs_psdev_file *pfile, unsigned long cmd, ...@@ -144,7 +144,7 @@ static int libcfs_ioctl_handle(struct cfs_psdev_file *pfile, unsigned long cmd,
data->ioc_inlbuf1[data->ioc_inllen1 - 1] != '\0') data->ioc_inlbuf1[data->ioc_inllen1 - 1] != '\0')
return -EINVAL; return -EINVAL;
libcfs_debug_mark_buffer(data->ioc_inlbuf1); libcfs_debug_mark_buffer(data->ioc_inlbuf1);
return 0; break;
default: { default: {
struct libcfs_ioctl_handler *hand; struct libcfs_ioctl_handler *hand;
...@@ -161,8 +161,7 @@ static int libcfs_ioctl_handle(struct cfs_psdev_file *pfile, unsigned long cmd, ...@@ -161,8 +161,7 @@ static int libcfs_ioctl_handle(struct cfs_psdev_file *pfile, unsigned long cmd,
} }
} }
up_read(&ioctl_list_sem); up_read(&ioctl_list_sem);
break; break; }
}
} }
return err; return err;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment