Commit 758684e4 authored by Somnath Kotur's avatar Somnath Kotur Committed by David S. Miller

bnxt_en: Fix static checker warning in bnxt_fw_reset_task()

Now that we return when bnxt_open() fails in bnxt_fw_reset_task(),
there is no need to check for 'rc' value again before invoking
bnxt_reenable_sriov().

Fixes: 3958b1da ("bnxt_en: fix error path of FW reset")
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarSomnath Kotur <somnath.kotur@broadcom.com>
Signed-off-by: default avatarMichael Chan <michael.chan@broadcom.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 92766c46
...@@ -12131,9 +12131,8 @@ static void bnxt_fw_reset_task(struct work_struct *work) ...@@ -12131,9 +12131,8 @@ static void bnxt_fw_reset_task(struct work_struct *work)
/* Make sure fw_reset_state is 0 before clearing the flag */ /* Make sure fw_reset_state is 0 before clearing the flag */
smp_mb__before_atomic(); smp_mb__before_atomic();
clear_bit(BNXT_STATE_IN_FW_RESET, &bp->state); clear_bit(BNXT_STATE_IN_FW_RESET, &bp->state);
bnxt_ulp_start(bp, rc); bnxt_ulp_start(bp, 0);
if (!rc) bnxt_reenable_sriov(bp);
bnxt_reenable_sriov(bp);
bnxt_vf_reps_alloc(bp); bnxt_vf_reps_alloc(bp);
bnxt_vf_reps_open(bp); bnxt_vf_reps_open(bp);
bnxt_dl_health_recovery_done(bp); bnxt_dl_health_recovery_done(bp);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment