Commit 7590ac22 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Takashi Iwai

ALSA: aoa: avoid false-positive format truncation warning

clang warns about what it interprets as a truncated snprintf:

sound/aoa/soundbus/i2sbus/core.c:171:6: error: 'snprintf' will always be truncated; specified size is 6, but format string expands to at least 7 [-Werror,-Wformat-truncation-non-kprintf]

The actual problem here is that it does not understand the special
%pOFn format string and assumes that it is a pointer followed by
the string "OFn", which would indeed not fit.

Slightly increasing the size of the buffer to its natural alignment
avoids the warning, as it is now long enough for the correct and
the incorrect interprations.

Fixes: b917d58d ("ALSA: aoa: Convert to using %pOFn instead of device_node.name")
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Message-ID: <20240326223825.4084412-9-arnd@kernel.org>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 051e0840
...@@ -158,7 +158,7 @@ static int i2sbus_add_dev(struct macio_dev *macio, ...@@ -158,7 +158,7 @@ static int i2sbus_add_dev(struct macio_dev *macio,
struct device_node *child, *sound = NULL; struct device_node *child, *sound = NULL;
struct resource *r; struct resource *r;
int i, layout = 0, rlen, ok = force; int i, layout = 0, rlen, ok = force;
char node_name[6]; char node_name[8];
static const char *rnames[] = { "i2sbus: %pOFn (control)", static const char *rnames[] = { "i2sbus: %pOFn (control)",
"i2sbus: %pOFn (tx)", "i2sbus: %pOFn (tx)",
"i2sbus: %pOFn (rx)" }; "i2sbus: %pOFn (rx)" };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment